Perl::Critic::Policy::InputOutput::RequireCheckedClose - Write C<< my $error = close $fh; >> instead of C<< close $fh; >>. |
Perl::Critic::Policy::InputOutput::RequireCheckedClose - Write my $error = close $fh;
instead of close $fh;
.
This Policy is part of the core Perl::Critic distribution.
The perl builtin I/O function close
returns a false value on
failure. That value should be checked to ensure that the close was
successful.
my $error = close $filehandle; # ok close $filehandle or die "unable to close: $!"; # ok close $filehandle; # not ok
use autodie qw< :io >; close $filehandle; # ok
You can use autodie, Fatal, or Fatal::Exception to get around this. Currently, autodie is not properly treated as a pragma; its lexical effects aren't taken into account.
This Policy is not configurable except for the standard options.
Andrew Moore <amoore@mooresystems.com>
This policy module is based heavily on policies written by Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>.
Copyright (c) 2007-2011 Andrew Moore. All rights reserved.
This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.
Perl::Critic::Policy::InputOutput::RequireCheckedClose - Write C<< my $error = close $fh; >> instead of C<< close $fh; >>. |